Made sensor HIL configurable, fixed runtime warnings, WIP

src/comm/QGCFlightGearLink.h

@@ -79,6 +79,10 @@ public:
         return -1;
     }
 
+    bool sensorHilEnabled() {
+        return _sensorHilEnabled;
+    }
+
     void run();
 
 public slots:
@@ -104,6 +108,12 @@ public slots:
         Q_UNUSED(airframe);
     }
 
+    void enableSensorHIL(bool enable) {
+        if (enable != _sensorHilEnabled)
+            _sensorHilEnabled = enable;
+            emit sensorHilChanged(enable);
+    }
+
     void readBytes();
     /**
      * @brief Write a number of bytes to the interface.
@@ -144,6 +154,7 @@ protected:
     QProcess* terraSync;
     unsigned int flightGearVersion;
     QString startupArguments;
+    bool _sensorHilEnabled;
 
     void setName(QString name);
 

src/comm/QGCHilLink.h

@@ -37,6 +37,12 @@ public:
      */
     virtual int getAirFrameIndex() = 0;
 
+    /**
+     * @brief Check if sensor level HIL is enabled
+     * @return true if sensor HIL is enabled
+     */
+    virtual bool sensorHilEnabled() = 0;
+
 public slots:
     virtual void setPort(int port) = 0;
     /** @brief Add a new host to broadcast messages to */
@@ -47,6 +53,8 @@ public slots:
     virtual void processError(QProcess::ProcessError err) = 0;
     /** @brief Set the simulator version as text string */
     virtual void setVersion(const QString& version) = 0;
+    /** @brief Enable sensor-level HIL (instead of state-level HIL) */
+    virtual void enableSensorHIL(bool enable) = 0;
 
     virtual void selectAirframe(const QString& airframe) = 0;
 
@@ -105,6 +113,9 @@ signals:
 
     /** @brief Selected sim version changed */
     void versionChanged(const QString& version);
+
+    /** @brief Sensor leve HIL state changed */
+    void sensorHilChanged(bool enabled);
 };
 
 #endif // QGCHILLINK_H

src/comm/QGCJSBSimLink.h

@@ -81,6 +81,10 @@ public:
 
     void run();
 
+    bool sensorHilEnabled() {
+        return _sensorHilEnabled;
+    }
+
 public slots:
 //    void setAddress(QString address);
     void setPort(int port);
@@ -104,6 +108,12 @@ public slots:
         script = airframe;
     }
 
+    void enableSensorHIL(bool enable) {
+        if (enable != _sensorHilEnabled)
+            _sensorHilEnabled = enable;
+            emit sensorHilChanged(enable);
+    }
+
     void readBytes();
     /**
      * @brief Write a number of bytes to the interface.
@@ -142,6 +152,7 @@ protected:
     unsigned int flightGearVersion;
     QString startupArguments;
     QString script;
+    bool _sensorHilEnabled;
 
     void setName(QString name);
 

src/comm/QGCXPlaneLink.cc

@@ -54,7 +54,7 @@ QGCXPlaneLink::QGCXPlaneLink(UASInterface* mav, QString remoteHost, QHostAddress
     simUpdateLast(QGC::groundTimeMilliseconds()),
     simUpdateLastText(QGC::groundTimeMilliseconds()),
     simUpdateHz(0),
-    sensorHilEnabled(true)
+    _sensorHilEnabled(true)
 {
     this->localHost = localHost;
     this->localPort = localPort/*+mav->getUASID()*/;
@@ -81,6 +81,7 @@ void QGCXPlaneLink::loadSettings()
     setRemoteHost(settings.value("REMOTE_HOST", QString("%1:%2").arg(remoteHost.toString()).arg(remotePort)).toString());
     setVersion(settings.value("XPLANE_VERSION", 10).toInt());
     selectAirframe(settings.value("AIRFRAME", "default").toString());
+    _sensorHilEnabled = settings.value("SENSOR_HIL", _sensorHilEnabled).toBool();
     settings.endGroup();
 }
 
@@ -92,6 +93,7 @@ void QGCXPlaneLink::storeSettings()
     settings.setValue("REMOTE_HOST", QString("%1:%2").arg(remoteHost.toString()).arg(remotePort));
     settings.setValue("XPLANE_VERSION", xPlaneVersion);
     settings.setValue("AIRFRAME", airframeName);
+    settings.setValue("SENSOR_HIL", _sensorHilEnabled);
     settings.endGroup();
     settings.sync();
 }
@@ -623,7 +625,7 @@ void QGCXPlaneLink::readBytes()
         }
         simUpdateLast = QGC::groundTimeMilliseconds();
 
-        if (sensorHilEnabled)
+        if (_sensorHilEnabled)
         {
             diff_pressure = 0.0f;
             pressure_alt = alt;

src/comm/QGCXPlaneLink.h

@@ -91,6 +91,20 @@ public:
         AIRFRAME_FIXED_WING_BIXLER_II_AILERONS
     };
 
+    QString getVersion()
+    {
+        return QString("X-Plane %1").arg(xPlaneVersion);
+    }
+
+    int getAirFrameIndex()
+    {
+        return (int)airframeID;
+    }
+
+    bool sensorHilEnabled() {
+        return _sensorHilEnabled;
+    }
+
 public slots:
 //    void setAddress(QString address);
     void setPort(int port);
@@ -104,14 +118,11 @@ public slots:
     void setVersion(const QString& version);
     /** @brief Set the simulator version as integer */
     void setVersion(unsigned int version);
-    QString getVersion()
-    {
-        return QString("X-Plane %1").arg(xPlaneVersion);
-    }
 
-    int getAirFrameIndex()
-    {
-        return (int)airframeID;
+    void enableSensorHIL(bool enable) {
+        if (enable != _sensorHilEnabled)
+            _sensorHilEnabled = enable;
+            emit sensorHilChanged(enable);
     }
 
     void processError(QProcess::ProcessError err);
@@ -194,10 +205,9 @@ protected:
     quint64 simUpdateLast;
     quint64 simUpdateLastText;
     float simUpdateHz;
-    bool sensorHilEnabled;
+    bool _sensorHilEnabled;
 
     void setName(QString name);
-
 };
 
 #endif // QGCXPLANESIMULATIONLINK_H

src/configuration.h

@@ -12,14 +12,14 @@
 #define WITH_TEXT_TO_SPEECH 1
 
 #define QGC_APPLICATION_NAME "QGroundControl"
-#define QGC_APPLICATION_VERSION "v. 1.0.4 (beta)"
+#define QGC_APPLICATION_VERSION "v. 1.0.2 (beta)"
 
 namespace QGC
 
 {
 const QString APPNAME = "QGROUNDCONTROL";
 const QString COMPANYNAME = "QGROUNDCONTROL";
-const int APPLICATIONVERSION = 104; // 1.0.4
+const int APPLICATIONVERSION = 105; // 1.0.4
 }
 
 #endif // QGC_CONFIGURATION_H

src/ui/MainWindow.cc

@@ -236,9 +236,10 @@ MainWindow::MainWindow(QWidget *parent):
         const int screenWidth = QApplication::desktop()->width();
         const int screenHeight = QApplication::desktop()->height();
 
-        if (screenWidth < 1200)
+        if (screenWidth < 1400)
         {
-            showFullScreen();
+            resize(screenWidth, screenHeight - 80);
+            show();
         }
         else
         {
@@ -680,7 +681,7 @@ void MainWindow::showHILConfigurationWidget(UASInterface* uas)
         QDockWidget* hilDock = new QDockWidget(hilDockName, this);
         hilDock->setWidget(hconf);
         hilDock->setObjectName(QString("HIL_CONFIG_%1").arg(uas->getUASID()));
-        addTool(hilDock, hilDockName, Qt::RightDockWidgetArea);
+        addTool(hilDock, hilDockName, Qt::LeftDockWidgetArea);
         hilDocks.insert(mav->getUASID(), hilDock);
 
         if (currentView != VIEW_SIMULATION)

src/ui/MainWindow.ui

@@ -497,7 +497,7 @@
      <normaloff>:/files/images/control/launch.svg</normaloff>:/files/images/control/launch.svg</iconset>
    </property>
    <property name="text">
-    <string>Simulation View</string>
+    <string>Simulation</string>
    </property>
    <property name="toolTip">
     <string>Open the simulation view</string>

src/ui/QGCHilConfiguration.cc

@@ -1,3 +1,5 @@
+#include <QSettings>
+
 #include "QGCHilConfiguration.h"
 #include "ui_QGCHilConfiguration.h"
 
@@ -11,6 +13,22 @@ QGCHilConfiguration::QGCHilConfiguration(UAS *mav, QWidget *parent) :
     ui(new Ui::QGCHilConfiguration)
 {
     ui->setupUi(this);
+
+    // XXX its quite wrong that this is implicitely a factory
+    // class, but this is something to clean up for later.
+
+    QSettings settings;
+    int i = settings.value("SIMULATOR_INDEX", -1).toInt();
+    settings.beginGroup("QGC_HILCONFIG");
+
+    if (i > 0) {
+        on_simComboBox_currentIndexChanged(i);
+        ui->simComboBox->blockSignals(true);
+        ui->simComboBox->setCurrentIndex(i);
+        ui->simComboBox->blockSignals(false);
+    }
+
+    settings.endGroup();
 }
 
 void QGCHilConfiguration::receiveStatusMessage(const QString& message)
@@ -20,6 +38,11 @@ void QGCHilConfiguration::receiveStatusMessage(const QString& message)
 
 QGCHilConfiguration::~QGCHilConfiguration()
 {
+    QSettings settings;
+    settings.beginGroup("QGC_HILCONFIG");
+    settings.setValue("SIMULATOR_INDEX", ui->simComboBox->currentIndex());
+    settings.endGroup();
+    settings.sync();
     delete ui;
 }
 
@@ -29,8 +52,8 @@ void QGCHilConfiguration::on_simComboBox_currentIndexChanged(int index)
     QLayoutItem *child;
     while ((child = ui->simulatorConfigurationLayout->takeAt(0)) != 0)
     {
-      delete child->widget();
-      delete child;
+        delete child->widget();
+        delete child;
     }
 
     if(1 == index)

src/ui/QGCHilXPlaneConfiguration.cc

@@ -27,6 +27,11 @@ QGCHilXPlaneConfiguration::QGCHilXPlaneConfiguration(QGCHilLink* link, QWidget *
 //        connect(ui->randomPositionButton, SIGNAL(clicked()), link, SLOT(setRandomPosition()));
         connect(ui->airframeComboBox, SIGNAL(activated(QString)), link, SLOT(selectAirframe(QString)));
         ui->airframeComboBox->setCurrentIndex(link->getAirFrameIndex());
+        // XXX not implemented yet
+        ui->airframeComboBox->hide();
+        ui->sensorHilCheckBox->setChecked(link->sensorHilEnabled());
+        connect(link, SIGNAL(sensorHilChanged(bool)), ui->sensorHilCheckBox, SLOT(setChecked(bool)));
+        connect(ui->sensorHilCheckBox, SIGNAL(clicked(bool)), link, SLOT(enableSensorHIL(bool)));
     }
 
     ui->hostComboBox->clear();

src/ui/QGCHilXPlaneConfiguration.ui

@@ -6,14 +6,14 @@
    <rect>
     <x>0</x>
     <y>0</y>
-    <width>249</width>
-    <height>100</height>
+    <width>295</width>
+    <height>148</height>
    </rect>
   </property>
   <property name="windowTitle">
    <string>Form</string>
   </property>
-  <layout class="QGridLayout" name="gridLayout" columnstretch="40,0,0,0">
+  <layout class="QGridLayout" name="gridLayout" rowstretch="0,0,0,0,0,100" columnstretch="40,10,10,40">
    <property name="margin">
     <number>0</number>
    </property>
@@ -24,19 +24,6 @@
      </property>
     </widget>
    </item>
-   <item row="5" column="0">
-    <spacer name="verticalSpacer">
-     <property name="orientation">
-      <enum>Qt::Vertical</enum>
-     </property>
-     <property name="sizeHint" stdset="0">
-      <size>
-       <width>20</width>
-       <height>40</height>
-      </size>
-     </property>
-    </spacer>
-   </item>
    <item row="0" column="1" colspan="3">
     <widget class="QComboBox" name="airframeComboBox">
      <property name="editable">
@@ -127,6 +114,26 @@
      </property>
     </widget>
    </item>
+   <item row="4" column="0" colspan="4">
+    <widget class="QCheckBox" name="sensorHilCheckBox">
+     <property name="text">
+      <string>Enable sensor level HIL</string>
+     </property>
+    </widget>
+   </item>
+   <item row="5" column="0" colspan="4">
+    <spacer name="verticalSpacer">
+     <property name="orientation">
+      <enum>Qt::Vertical</enum>
+     </property>
+     <property name="sizeHint" stdset="0">
+      <size>
+       <width>20</width>
+       <height>1</height>
+      </size>
+     </property>
+    </spacer>
+   </item>
   </layout>
  </widget>
  <resources/>

src/ui/map3D/SystemViewParams.cc

@@ -18,6 +18,7 @@ SystemViewParams::SystemViewParams(int systemId)
  , mSetpointHistoryLength(100)
 {
 
+    setObjectName("RGBD VIEW PARAMS");
 }
 
 bool&

src/ui/map3D/ViewParamWidget.cc

@@ -19,6 +19,7 @@ ViewParamWidget::ViewParamWidget(GlobalViewParamsPtr& globalViewParams,
  , mFollowCameraComboBox(new QComboBox(this))
  , mTabWidget(new QTabWidget(this))
 {
+    setObjectName("RGBD VIEW PARAMS WIDGET");
     QVBoxLayout* layout = new QVBoxLayout;
     QWidget* widget = new QWidget;
     widget->setLayout(layout);