Show how to implement custom video manager

custom-example/custom.pri

@@ -58,11 +58,13 @@ QML_IMPORT_PATH += \
 # Our own, custom sources
 SOURCES += \
     $$PWD/src/CustomPlugin.cc \
-    $$PWD/src/CustomQuickInterface.cc
+    $$PWD/src/CustomQuickInterface.cc \
+    $$PWD/src/CustomVideoManager.cc
 
 HEADERS += \
     $$PWD/src/CustomPlugin.h \
-    $$PWD/src/CustomQuickInterface.h
+    $$PWD/src/CustomQuickInterface.h \
+    $$PWD/src/CustomVideoManager.h
 
 INCLUDEPATH += \
     $$PWD/src \

custom-example/src/CustomPlugin.cc

@@ -17,6 +17,7 @@
 
 #include "CustomPlugin.h"
 #include "CustomQuickInterface.h"
+#include "CustomVideoManager.h"
 
 #include "MultiVehicleManager.h"
 #include "QGCApplication.h"
@@ -192,6 +193,13 @@ CustomPlugin::overrideSettingsGroupVisibility(QString name)
 }
 
 //-----------------------------------------------------------------------------
+VideoManager*
+CustomPlugin::createVideoManager(QGCApplication *app, QGCToolbox *toolbox)
+{
+    return new CustomVideoManager(app, toolbox);
+}
+
+//-----------------------------------------------------------------------------
 VideoReceiver*
 CustomPlugin::createVideoReceiver(QObject* parent)
 {

custom-example/src/CustomPlugin.h

@@ -79,6 +79,7 @@ public:
     QString                 brandImageIndoor                () const final;
     QString                 brandImageOutdoor               () const final;
     bool                    overrideSettingsGroupVisibility (QString name) final;
+    VideoManager*           createVideoManager              (QGCApplication* app, QGCToolbox* toolbox) final;
     VideoReceiver*          createVideoReceiver             (QObject* parent) final;
     QQmlApplicationEngine*  createRootWindow                (QObject* parent) final;
     bool                    adjustSettingMetaData           (const QString& settingsGroup, FactMetaData& metaData) final;

custom-example/src/CustomVideoManager.cc

@@ -0,0 +1,39 @@
+/****************************************************************************
+ *
+ *   (c) 2009-2019 QGROUNDCONTROL PROJECT <http://www.qgroundcontrol.org>
+ *
+ * QGroundControl is licensed according to the terms in the file
+ * COPYING.md in the root of the source code directory.
+ *
+ ****************************************************************************/
+
+#include "CustomVideoManager.h"
+#include "MultiVehicleManager.h"
+#include "CustomCameraManager.h"
+#include "CustomCameraControl.h"
+
+//-----------------------------------------------------------------------------
+CustomVideoManager::CustomVideoManager(QGCApplication* app, QGCToolbox* toolbox)
+    : VideoManager(app, toolbox)
+{
+}
+
+//-----------------------------------------------------------------------------
+void
+CustomVideoManager::_updateSettings()
+{
+    if(!_videoSettings || !_videoReceiver)
+        return;
+    //-- Check encoding
+    if(_activeVehicle && _activeVehicle->dynamicCameras()) {
+        CustomCameraControl* pCamera = dynamic_cast<CustomCameraControl*>(_activeVehicle->dynamicCameras()->currentCameraInstance());
+        if(pCamera) {
+            Fact *fact = pCamera->videoEncoding();
+            if (fact) {
+                _videoReceiver->setVideoDecoder(static_cast<VideoReceiver::VideoEncoding>(fact->rawValue().toInt()));
+            }
+        }
+    }
+    VideoManager::_updateSettings();
+}
+

custom-example/src/CustomVideoManager.h

@@ -0,0 +1,28 @@
+/****************************************************************************
+ *
+ *   (c) 2009-2019 QGROUNDCONTROL PROJECT <http://www.qgroundcontrol.org>
+ *
+ * QGroundControl is licensed according to the terms in the file
+ * COPYING.md in the root of the source code directory.
+ *
+ ****************************************************************************/
+
+#pragma once
+
+#include <QObject>
+#include <QTimer>
+#include <QTime>
+#include <QUrl>
+
+#include "VideoManager.h"
+
+class CustomVideoManager : public VideoManager
+{
+    Q_OBJECT
+public:
+    CustomVideoManager      (QGCApplication* app, QGCToolbox* toolbox);
+
+protected:
+    void _updateSettings    ();
+
+};

custom-example/src/FirmwarePlugin/CustomCameraControl.cc

@@ -19,6 +19,7 @@ QGC_LOGGING_CATEGORY(CustomCameraVerboseLog, "CustomCameraVerboseLog")
 
 static const char* kCAM_IRPALETTE            = "CAM_IRPALETTE";
 static const char* kCAM_NEXTVISION_IRPALETTE = "IR_SENS_POL";
+static const char* kCAM_ENC                  = "CAM_ENC";
 
 //-----------------------------------------------------------------------------
 CustomCameraControl::CustomCameraControl(const mavlink_camera_information_t *info, Vehicle* vehicle, int compID, QObject* parent)
@@ -117,6 +118,13 @@ CustomCameraControl::irPalette()
 }
 
 //-----------------------------------------------------------------------------
+Fact*
+CustomCameraControl::videoEncoding()
+{
+    return _paramComplete ? getFact(kCAM_ENC) : nullptr;
+}
+
+//-----------------------------------------------------------------------------
 void
 CustomCameraControl::setThermalMode(ThermalViewMode mode)
 {

custom-example/src/FirmwarePlugin/CustomCameraControl.h

@@ -29,8 +29,11 @@ public:
     CustomCameraControl(const mavlink_camera_information_t* info, Vehicle* vehicle, int compID, QObject* parent = nullptr);
 
     Q_PROPERTY(Fact*        irPalette       READ    irPalette           NOTIFY parametersReady)
+    Q_PROPERTY(Fact*        videoEncoding   READ    videoEncoding       NOTIFY parametersReady)
 
     Fact*       irPalette           ();
+    Fact*       videoEncoding       ();
+
     bool        takePhoto           () override;
     bool        stopTakePhoto       () override;
     bool        startVideo          () override;

src/Camera/QGCCameraControl.cc

@@ -70,9 +70,6 @@ const char* QGCCameraControl::kCAM_SHUTTERSPD  = "CAM_SHUTTERSPD";
 const char* QGCCameraControl::kCAM_APERTURE    = "CAM_APERTURE";
 const char* QGCCameraControl::kCAM_WBMODE      = "CAM_WBMODE";
 const char* QGCCameraControl::kCAM_MODE        = "CAM_MODE";
-const char* QGCCameraControl::kCAM_BITRATE     = "CAM_BITRATE";
-const char* QGCCameraControl::kCAM_FPS         = "CAM_FPS";
-const char* QGCCameraControl::kCAM_ENC         = "CAM_ENC";
 
 //-----------------------------------------------------------------------------
 QGCCameraOptionExclusion::QGCCameraOptionExclusion(QObject* parent, QString param_, QString value_, QStringList exclusions_)
@@ -2117,27 +2114,6 @@ QGCCameraControl::mode()
 }
 
 //-----------------------------------------------------------------------------
-Fact*
-QGCCameraControl::bitRate()
-{
-    return _paramComplete ? getFact(kCAM_BITRATE) : nullptr;
-}
-
-//-----------------------------------------------------------------------------
-Fact*
-QGCCameraControl::frameRate()
-{
-    return _paramComplete ? getFact(kCAM_FPS) : nullptr;
-}
-
-//-----------------------------------------------------------------------------
-Fact*
-QGCCameraControl::videoEncoding()
-{
-    return _paramComplete ? getFact(kCAM_ENC) : nullptr;
-}
-
-//-----------------------------------------------------------------------------
 QGCVideoStreamInfo::QGCVideoStreamInfo(QObject* parent, const mavlink_video_stream_information_t *si)
     : QObject(parent)
 {

src/Camera/QGCCameraControl.h

@@ -167,9 +167,6 @@ public:
     Q_PROPERTY(Fact*        aperture            READ aperture           NOTIFY parametersReady)
     Q_PROPERTY(Fact*        wb                  READ wb                 NOTIFY parametersReady)
     Q_PROPERTY(Fact*        mode                READ mode               NOTIFY parametersReady)
-    Q_PROPERTY(Fact*        bitRate             READ bitRate            NOTIFY parametersReady)
-    Q_PROPERTY(Fact*        frameRate           READ frameRate          NOTIFY parametersReady)
-    Q_PROPERTY(Fact*        videoEncoding       READ videoEncoding      NOTIFY parametersReady)
 
     Q_PROPERTY(QStringList  activeSettings      READ activeSettings                                 NOTIFY activeSettingsChanged)
     Q_PROPERTY(VideoStatus  videoStatus         READ videoStatus                                    NOTIFY videoStatusChanged)
@@ -255,9 +252,6 @@ public:
     virtual Fact*       aperture            ();
     virtual Fact*       wb                  ();
     virtual Fact*       mode                ();
-    virtual Fact*       bitRate             ();
-    virtual Fact*       frameRate           ();
-    virtual Fact*       videoEncoding       ();
 
     //-- Stream names to show the user (for selection)
     virtual QStringList streamLabels        () { return _streamLabels; }
@@ -289,7 +283,6 @@ public:
     //-- Allow controller to modify or invalidate parameter change
     virtual bool        validateParameter   (Fact* pFact, QVariant& newValue);
 
-
     // Known Parameters
     static const char* kCAM_EV;
     static const char* kCAM_EXPMODE;
@@ -298,9 +291,6 @@ public:
     static const char* kCAM_APERTURE;
     static const char* kCAM_WBMODE;
     static const char* kCAM_MODE;
-    static const char* kCAM_BITRATE;
-    static const char* kCAM_FPS;
-    static const char* kCAM_ENC;
 
 signals:
     void    infoChanged                     ();

src/FlightDisplay/VideoManager.cc

@@ -279,13 +279,6 @@ VideoManager::_updateSettings()
         return;
     //-- Auto discovery
     if(_activeVehicle && _activeVehicle->dynamicCameras()) {
-        QGCCameraControl* pCamera = _activeVehicle->dynamicCameras()->currentCameraInstance();
-        if(pCamera) {
-            Fact *fact = pCamera->videoEncoding();
-            if (fact) {
-                _videoReceiver->setVideoDecoder(static_cast<VideoReceiver::VideoEncoding>(fact->rawValue().toInt()));
-            }
-        }
         QGCVideoStreamInfo* pInfo = _activeVehicle->dynamicCameras()->currentStreamInstance();
         if(pInfo) {
             qCDebug(VideoManagerLog) << "Configure primary stream: " << pInfo->uri();

src/FlightDisplay/VideoManager.h

@@ -34,7 +34,7 @@ class VideoManager : public QGCTool
 
 public:
     VideoManager    (QGCApplication* app, QGCToolbox* toolbox);
-    ~VideoManager   ();
+    virtual ~VideoManager   ();
 
     Q_PROPERTY(bool             hasVideo                READ    hasVideo                                    NOTIFY hasVideoChanged)
     Q_PROPERTY(bool             isGStreamer             READ    isGStreamer                                 NOTIFY isGStreamerChanged)
@@ -51,34 +51,33 @@ public:
     Q_PROPERTY(bool             autoStreamConfigured    READ    autoStreamConfigured                        NOTIFY autoStreamConfiguredChanged)
     Q_PROPERTY(bool             hasThermal              READ    hasThermal                                  NOTIFY aspectRatioChanged)
 
-    bool        hasVideo            ();
+    virtual bool        hasVideo            ();
-    bool        isGStreamer         ();
+    virtual bool        isGStreamer         ();
-    bool        isAutoStream        ();
+    virtual bool        isTaisync           () { return _isTaisync; }
-    bool        isTaisync           () { return _isTaisync; }
+    virtual bool        fullScreen          () { return _fullScreen; }
-    bool        fullScreen          () { return _fullScreen; }
+    virtual QString     videoSourceID       () { return _videoSourceID; }
-    QString     videoSourceID       () { return _videoSourceID; }
+    virtual double      aspectRatio         ();
-    double      aspectRatio         ();
+    virtual double      thermalAspectRatio  ();
-    double      thermalAspectRatio  ();
+    virtual double      hfov                ();
-    double      hfov                ();
+    virtual double      thermalHfov         ();
-    double      thermalHfov         ();
+    virtual bool        autoStreamConfigured();
-    bool        autoStreamConfigured();
+    virtual bool        hasThermal          ();
-    bool        hasThermal          ();
+    virtual void        restartVideo        ();
-    void        restartVideo        ();
+
-
+    virtual VideoReceiver*  videoReceiver           () { return _videoReceiver; }
-    VideoReceiver*  videoReceiver           () { return _videoReceiver; }
+    virtual VideoReceiver*  thermalVideoReceiver    () { return _thermalVideoReceiver; }
-    VideoReceiver*  thermalVideoReceiver    () { return _thermalVideoReceiver; }
 
 #if defined(QGC_DISABLE_UVC)
-    bool        uvcEnabled          () { return false; }
+    virtual bool        uvcEnabled          () { return false; }
 #else
-    bool        uvcEnabled          ();
+    virtual bool        uvcEnabled          ();
 #endif
 
-    void        setfullScreen       (bool f) { _fullScreen = f; emit fullScreenChanged(); }
+    virtual void        setfullScreen       (bool f) { _fullScreen = f; emit fullScreenChanged(); }
-    void        setIsTaisync        (bool t) { _isTaisync = t;  emit isTaisyncChanged(); }
+    virtual void        setIsTaisync        (bool t) { _isTaisync = t;  emit isTaisyncChanged(); }
 
     // Override from QGCTool
-    void        setToolbox          (QGCToolbox *toolbox);
+    virtual void        setToolbox          (QGCToolbox *toolbox);
 
     Q_INVOKABLE void startVideo     ();
     Q_INVOKABLE void stopVideo      ();
@@ -93,7 +92,7 @@ signals:
     void aspectRatioChanged         ();
     void autoStreamConfiguredChanged();
 
-private slots:
+protected slots:
     void _videoSourceChanged        ();
     void _udpPortChanged            ();
     void _rtspUrlChanged            ();
@@ -102,10 +101,10 @@ private slots:
     void _setActiveVehicle          (Vehicle* vehicle);
     void _aspectRatioChanged        ();
 
-private:
+protected:
     void _updateSettings            ();
 
-private:
+protected:
     SubtitleWriter  _subtitleWriter;
     bool            _isTaisync              = false;
     VideoReceiver*  _videoReceiver          = nullptr;

src/VideoStreaming/VideoReceiver.cc

@@ -611,14 +611,14 @@ VideoReceiver::setVideoDecoder(VideoEncoding encoding)
     */
 
     if (encoding == H265_HW || encoding == H265_SW) {
-        _depayName = "rtph265depay";
+        _depayName  = "rtph265depay";
         _parserName = "h265parse";
 #if defined(__android__)
         _hwDecoderName = "amcviddec-omxgooglehevcdecoder";
 #endif
         _swDecoderName = "avdec_h265";
     } else {
-        _depayName = "rtph264depay";
+        _depayName  = "rtph264depay";
         _parserName = "h264parse";
 #if defined(__android__)
         _hwDecoderName = "amcviddec-omxgoogleh264decoder";
@@ -630,6 +630,7 @@ VideoReceiver::setVideoDecoder(VideoEncoding encoding)
         _hwDecoderName = nullptr;
     }
 }
+
 //-----------------------------------------------------------------------------
 // When we finish our pipeline will look like this:
 //

src/api/QGCCorePlugin.cc

@@ -15,6 +15,7 @@
 #include "SettingsManager.h"
 #include "AppMessages.h"
 #include "QmlObjectListModel.h"
+#include "VideoManager.h"
 #include "VideoReceiver.h"
 #include "QGCLoggingCategory.h"
 #include "QGCCameraManager.h"
@@ -408,6 +409,11 @@ QmlObjectListModel* QGCCorePlugin::customMapItems()
     return &_p->_emptyCustomMapItems;
 }
 
+VideoManager* QGCCorePlugin::createVideoManager(QGCApplication *app, QGCToolbox *toolbox)
+{
+    return new VideoManager(app, toolbox);
+}
+
 VideoReceiver* QGCCorePlugin::createVideoReceiver(QObject* parent)
 {
     return new VideoReceiver(parent);

src/api/QGCCorePlugin.h

@@ -104,6 +104,8 @@ public:
     /// Allows the plugin to override the creation of the root (native) window.
     virtual QQmlApplicationEngine* createRootWindow(QObject* parent);
 
+    /// Allows the plugin to override the creation of VideoManager.
+    virtual VideoManager* createVideoManager(QGCApplication* app, QGCToolbox* toolbox);
     /// Allows the plugin to override the creation of VideoReceiver.
     virtual VideoReceiver* createVideoReceiver(QObject* parent);