Crash fixes and changes for better info (#9073)

Rework to prevent crashes from nullptr returns from getUIInfo/getParamInfo

src/MissionManager/MissionCommandTree.cc

@@ -161,6 +161,22 @@ QString MissionCommandTree::rawName(MAV_CMD command)
     }
 }
 
+bool MissionCommandTree::isLandCommand(MAV_CMD command)
+{
+    MissionCommandList *    commandList =   _staticCommandTree[QGCMAVLink::FirmwareClassGeneric][QGCMAVLink::VehicleClassGeneric];
+    MissionCommandUIInfo*   uiInfo =        commandList->getUIInfo(command);
+
+    return uiInfo ? uiInfo->isLandCommand() : false;
+}
+
+bool MissionCommandTree::isTakeoffCommand(MAV_CMD command)
+{
+    MissionCommandList *    commandList =   _staticCommandTree[QGCMAVLink::FirmwareClassGeneric][QGCMAVLink::VehicleClassGeneric];
+    MissionCommandUIInfo*   uiInfo =        commandList->getUIInfo(command);
+
+    return uiInfo ? uiInfo->isTakeoffCommand() : false;
+}
+
 const QList<MAV_CMD>& MissionCommandTree::allCommandIds(void) const
 {
     return _staticCommandTree[QGCMAVLink::FirmwareClassGeneric][QGCMAVLink::VehicleClassGeneric]->commandIds();

src/MissionManager/MissionCommandTree.h

@@ -55,6 +55,9 @@ public:
     /// Returns the raw name for the specified command
     QString rawName(MAV_CMD command);
 
+    bool isLandCommand(MAV_CMD command);
+    bool isTakeoffCommand(MAV_CMD command);
+
     const QList<MAV_CMD>& allCommandIds(void) const;
 
     Q_INVOKABLE QStringList categoriesForVehicle(Vehicle* vehicle) { return _availableCategoriesForVehicle(vehicle); }

src/MissionManager/MissionController.cc

@@ -319,8 +319,7 @@ VisualMissionItem* MissionController::_insertSimpleMissionItemWorker(QGeoCoordin
     _initVisualItem(newItem);
 
     if (newItem->specifiesAltitude()) {
-        const MissionCommandUIInfo* uiInfo = qgcApp()->toolbox()->missionCommandTree()->getUIInfo(_controllerVehicle, QGCMAVLink::VehicleClassGeneric, command);
-        if (!uiInfo->isLandCommand()) {
+        if (!qgcApp()->toolbox()->missionCommandTree()->isLandCommand(command)) {
             double  prevAltitude;
             int     prevAltitudeMode;
 

src/MissionManager/SimpleMissionItem.cc

@@ -451,6 +451,7 @@ void SimpleMissionItem::_rebuildTextFieldFacts(void)
 
         const MissionCommandUIInfo* uiInfo = _commandTree->getUIInfo(_controllerVehicle, _previousVTOLMode, command);
 
+        if (uiInfo) {
             for (int i=1; i<=7; i++) {
                 bool showUI;
                 const MissionCmdParamInfo* paramInfo = uiInfo->getParamInfo(i, showUI);
@@ -466,6 +467,7 @@ void SimpleMissionItem::_rebuildTextFieldFacts(void)
                     _textFieldFacts.append(paramFact);
                 }
             }
+        }
 
         _ignoreDirtyChangeSignals = false;
     }
@@ -490,6 +492,7 @@ void SimpleMissionItem::_rebuildNaNFacts(void)
 
         const MissionCommandUIInfo* uiInfo = _commandTree->getUIInfo(_controllerVehicle, _previousVTOLMode, command);
 
+        if (uiInfo) {
             for (int i=1; i<=7; i++) {
                 bool showUI;
                 const MissionCmdParamInfo* paramInfo = uiInfo->getParamInfo(i, showUI);
@@ -512,6 +515,7 @@ void SimpleMissionItem::_rebuildNaNFacts(void)
                     _nanFacts.append(paramFact);
                 }
             }
+        }
 
         _ignoreDirtyChangeSignals = false;
     }
@@ -778,7 +782,8 @@ void SimpleMissionItem::_sendFriendlyEditAllowedChanged(void)
 
 QString SimpleMissionItem::category(void) const
 {
-    return _commandTree->getUIInfo(_controllerVehicle, _previousVTOLMode, static_cast<MAV_CMD>(command()))->category();
+    const MissionCommandUIInfo* uiInfo = _commandTree->getUIInfo(_controllerVehicle, _previousVTOLMode, static_cast<MAV_CMD>(command()));
+    return uiInfo ? uiInfo->category() : QString();
 }
 
 void SimpleMissionItem::setCommand(int command)
@@ -923,7 +928,7 @@ void SimpleMissionItem::applyNewAltitude(double newAltitude)
     MAV_CMD command = static_cast<MAV_CMD>(this->command());
     const MissionCommandUIInfo* uiInfo = _commandTree->getUIInfo(_controllerVehicle, _previousVTOLMode, command);
 
-    if (uiInfo->specifiesCoordinate() || uiInfo->specifiesAltitudeOnly()) {
+    if (uiInfo && (uiInfo->specifiesCoordinate() || uiInfo->specifiesAltitudeOnly())) {
         switch (static_cast<MAV_CMD>(this->command())) {
         case MAV_CMD_NAV_LAND:
         case MAV_CMD_NAV_VTOL_LAND:
@@ -989,9 +994,7 @@ void SimpleMissionItem::_possibleAdditionalTimeDelayChanged(void)
 
 bool SimpleMissionItem::isLandCommand(void) const
 {
-    MAV_CMD command = static_cast<MAV_CMD>(this->command());
-    const MissionCommandUIInfo* uiInfo = _commandTree->getUIInfo(_controllerVehicle, _previousVTOLMode, command);
-    return uiInfo->isLandCommand();
+    return _commandTree->isLandCommand(static_cast<MAV_CMD>(this->command()));
 }
 
 QGeoCoordinate SimpleMissionItem::coordinate(void) const

src/MissionManager/TakeoffMissionItem.cc

@@ -116,9 +116,7 @@ void TakeoffMissionItem::setCoordinate(const QGeoCoordinate& coordinate)
 
 bool TakeoffMissionItem::isTakeoffCommand(MAV_CMD command)
 {
-    const MissionCommandUIInfo* uiInfo = qgcApp()->toolbox()->missionCommandTree()->getUIInfo(qgcApp()->toolbox()->multiVehicleManager()->offlineEditingVehicle(), QGCMAVLink::VehicleClassGeneric, command);
-
-    return uiInfo ? uiInfo->isTakeoffCommand() : false;
+    return qgcApp()->toolbox()->missionCommandTree()->isTakeoffCommand(command);
 }
 
 void TakeoffMissionItem::_initLaunchTakeoffAtSameLocation(void)