Merge pull request #2170 from DonLakeFlyer/UT

Unit Tests that will run with QT_FATAL_WARNINGS=1

.travis.yml

@@ -22,7 +22,7 @@ matrix:
           sudo: false
         - os: osx
           osx_image: xcode7
-          env: SPEC=macx-clang CONFIG=debug
+          env: SPEC=macx-clang CONFIG=debug QT_FATAL_WARNINGS=1
         - os: osx
           osx_image: xcode7
           env: SPEC=macx-clang CONFIG=installer

src/VehicleSetup/SetupViewTest.cc

@@ -63,10 +63,6 @@ void SetupViewTest::_clickThrough_test(void)
         QTest::qWait(1000);
     }
 
-    // On MainWindow close we should get a message box telling the user to disconnect first.
+    _disconnectMockLink();
-    
-    setExpectedMessageBox(QGCMessageBox::Yes);
-    
     _closeMainWindow();
-    checkExpectedMessageBox();
 }

src/qgcunittest/UnitTest.cc

@@ -417,5 +417,9 @@ void UnitTest::_closeMainWindow(bool cancelExpected)
 
         mainWindowSpy.wait(2000);
         QCOMPARE(mainWindowSpy.count(), cancelExpected ? 0 : 1);
+
+        // This leaves enough time for any dangling Qml components to get cleaned up.
+        // This prevents qWarning from bad references in Qml
+        QTest::qWait(1000);
     }
 }