From 2dbd8519edec41903b5b74bb833b765f18b8948f Mon Sep 17 00:00:00 2001 From: Don Gagne Date: Sun, 26 Feb 2017 15:16:34 -0800 Subject: [PATCH] Consistent sizing between Combo and TextField Also correctly set implicitHeight on QGCTextField --- src/QmlControls/QGCComboBox.qml | 2 +- src/QmlControls/QGCTextField.qml | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/QmlControls/QGCComboBox.qml b/src/QmlControls/QGCComboBox.qml index 8b00e72..9950708 100644 --- a/src/QmlControls/QGCComboBox.qml +++ b/src/QmlControls/QGCComboBox.qml @@ -19,7 +19,7 @@ ComboBox { background: Item { implicitWidth: Math.round(ScreenTools.defaultFontPixelWidth * 4.5) - implicitHeight: ScreenTools.isMobile ? Math.max(25, Math.round(ScreenTools.defaultFontPixelHeight * 2)) : Math.max(25, Math.round(ScreenTools.defaultFontPixelHeight * 1.2)) + implicitHeight: Math.round(ScreenTools.defaultFontPixelHeight * (ScreenTools.isMobile ? 2 : 1.2)) Rectangle { anchors.fill: parent diff --git a/src/QmlControls/QGCTextField.qml b/src/QmlControls/QGCTextField.qml index 6542d29..502e428 100644 --- a/src/QmlControls/QGCTextField.qml +++ b/src/QmlControls/QGCTextField.qml @@ -26,7 +26,8 @@ TextField { QGCPalette { id: qgcPal; colorGroupEnabled: enabled } textColor: qgcPal.textFieldText - height: Math.round(Math.max(25, ScreenTools.defaultFontPixelHeight * (ScreenTools.isMobile ? 2.5 : 1.2))) + + implicitHeight: Math.round(ScreenTools.defaultFontPixelHeight * (ScreenTools.isMobile ? 2 : 1.2)) QGCLabel { id: unitsLabelWidthGenerator