Browse Source

px4firmwareplugin: fix minimum required version comparison

before, with a version of eg. 1.5.0, the user was wrongly notified.
QGC4.4
Beat Küng 9 years ago
parent
commit
4165c09fcb
  1. 10
      src/FirmwarePlugin/PX4/PX4FirmwarePlugin.cc

10
src/FirmwarePlugin/PX4/PX4FirmwarePlugin.cc

@ -459,7 +459,15 @@ void PX4FirmwarePlugin::_handleAutopilotVersion(Vehicle* vehicle, mavlink_messag @@ -459,7 +459,15 @@ void PX4FirmwarePlugin::_handleAutopilotVersion(Vehicle* vehicle, mavlink_messag
minorVersion = (version.flight_sw_version >> (8*2)) & 0xFF;
patchVersion = (version.flight_sw_version >> (8*1)) & 0xFF;
notifyUser = majorVersion < supportedMajorVersion || minorVersion < supportedMinorVersion || patchVersion < supportedPatchVersion;
if (majorVersion < supportedMajorVersion) {
notifyUser = true;
} else if (majorVersion == supportedMajorVersion) {
if (minorVersion < supportedMinorVersion) {
notifyUser = true;
} else if (minorVersion == supportedMinorVersion) {
notifyUser = patchVersion < supportedPatchVersion;
}
}
} else {
notifyUser = true;
}

Loading…
Cancel
Save