From 4d28975ddb9533504b0ca6a70f7b906882bbf252 Mon Sep 17 00:00:00 2001 From: Don Gagne Date: Sat, 29 Aug 2015 11:18:32 -0700 Subject: [PATCH] Don't emit useless signal --- src/Vehicle/MultiVehicleManager.cc | 20 +++++++++++--------- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/src/Vehicle/MultiVehicleManager.cc b/src/Vehicle/MultiVehicleManager.cc index fd55a9c..a60edf1 100644 --- a/src/Vehicle/MultiVehicleManager.cc +++ b/src/Vehicle/MultiVehicleManager.cc @@ -149,15 +149,17 @@ void MultiVehicleManager::_deleteVehiclePhase2 (void) void MultiVehicleManager::setActiveVehicle(Vehicle* vehicle) { if (vehicle != _activeVehicle) { - // The sequence of signals is very important in order to not leave Qml elements connected - // to a non-existent vehicle. - - // First we must signal that there is no active vehicle available. This will disconnect - // any existing ui from the currently active vehicle. - _activeVehicleAvailable = false; - _parameterReadyVehicleAvailable = false; - emit activeVehicleAvailableChanged(false); - emit parameterReadyVehicleAvailableChanged(false); + if (_activeVehicle) { + // The sequence of signals is very important in order to not leave Qml elements connected + // to a non-existent vehicle. + + // First we must signal that there is no active vehicle available. This will disconnect + // any existing ui from the currently active vehicle. + _activeVehicleAvailable = false; + _parameterReadyVehicleAvailable = false; + emit activeVehicleAvailableChanged(false); + emit parameterReadyVehicleAvailableChanged(false); + } // See explanation in _deleteVehiclePhase1 _vehicleBeingSetActive = vehicle;