Browse Source

Don't emit useless signal

QGC4.4
Don Gagne 10 years ago
parent
commit
4d28975ddb
  1. 20
      src/Vehicle/MultiVehicleManager.cc

20
src/Vehicle/MultiVehicleManager.cc

@ -149,15 +149,17 @@ void MultiVehicleManager::_deleteVehiclePhase2 (void)
void MultiVehicleManager::setActiveVehicle(Vehicle* vehicle) void MultiVehicleManager::setActiveVehicle(Vehicle* vehicle)
{ {
if (vehicle != _activeVehicle) { if (vehicle != _activeVehicle) {
// The sequence of signals is very important in order to not leave Qml elements connected if (_activeVehicle) {
// to a non-existent vehicle. // The sequence of signals is very important in order to not leave Qml elements connected
// to a non-existent vehicle.
// First we must signal that there is no active vehicle available. This will disconnect
// any existing ui from the currently active vehicle. // First we must signal that there is no active vehicle available. This will disconnect
_activeVehicleAvailable = false; // any existing ui from the currently active vehicle.
_parameterReadyVehicleAvailable = false; _activeVehicleAvailable = false;
emit activeVehicleAvailableChanged(false); _parameterReadyVehicleAvailable = false;
emit parameterReadyVehicleAvailableChanged(false); emit activeVehicleAvailableChanged(false);
emit parameterReadyVehicleAvailableChanged(false);
}
// See explanation in _deleteVehiclePhase1 // See explanation in _deleteVehiclePhase1
_vehicleBeingSetActive = vehicle; _vehicleBeingSetActive = vehicle;

Loading…
Cancel
Save