Browse Source

QmlControls: ParameterEditorController: Simplify shouldShow logic

Improve code readability and maintainability

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
QGC4.4
Patrick José Pereira 4 years ago committed by Don Gagne
parent
commit
4ea516e040
  1. 7
      src/QmlControls/ParameterEditorController.cc

7
src/QmlControls/ParameterEditorController.cc

@ -354,8 +354,11 @@ void ParameterEditorController::resetAllToVehicleConfiguration(void) @@ -354,8 +354,11 @@ void ParameterEditorController::resetAllToVehicleConfiguration(void)
bool ParameterEditorController::_shouldShow(Fact* fact) const
{
bool show = _showModifiedOnly ? (fact->defaultValueAvailable() ? (fact->valueEqualsDefault() ? false : true) : false) : true;
return show;
if (!_showModifiedOnly) {
return true;
}
return fact->defaultValueAvailable() && !fact->valueEqualsDefault();
}
void ParameterEditorController::_searchTextChanged(void)

Loading…
Cancel
Save