Merge pull request #5972 from DonLakeFlyer/VTOLTransitionReally

Make VTOL transition work

src/Vehicle/Vehicle.cc

@@ -994,7 +994,11 @@ void Vehicle::_handleExtendedSysState(mavlink_message_t& message)
     }
 
     if (vtol()) {
-        setVtolInFwdFlight(extendedState.vtol_state == MAV_VTOL_STATE_FW);
+        bool vtolInFwdFlight = extendedState.vtol_state == MAV_VTOL_STATE_FW;
+        if (vtolInFwdFlight != _vtolInFwdFlight) {
+            _vtolInFwdFlight = vtolInFwdFlight;
+            emit vtolInFwdFlightChanged(vtolInFwdFlight);
+        }
     }
 }
 
@@ -2688,8 +2692,11 @@ void Vehicle::triggerCamera(void)
 void Vehicle::setVtolInFwdFlight(bool vtolInFwdFlight)
 {
     if (_vtolInFwdFlight != vtolInFwdFlight) {
-        _vtolInFwdFlight = vtolInFwdFlight;
+        sendMavCommand(_defaultComponentId,
-        emit vtolInFwdFlightChanged(vtolInFwdFlight);
+                       MAV_CMD_DO_VTOL_TRANSITION,
+                       true,                                                    // show errors
+                       vtolInFwdFlight ? MAV_VTOL_STATE_FW : MAV_VTOL_STATE_MC, // transition state
+                       0, 0, 0, 0, 0, 0);                                       // param 2-7 unused
     }
 }