Merge pull request #8545 from alexeylysenko/remove_unreachable_code

Fixed suspicious if-expression

src/MissionManager/VisualMissionItem.cc

@@ -167,14 +167,10 @@ void VisualMissionItem::_updateTerrainAltitude(void)
         return;
     }
     if (!_flyView && specifiesCoordinate() && coordinate().isValid()) {
-        if (specifiesCoordinate()) {
+        // We use a timer so that any additional requests before the timer fires result in only a single request
-            if (coordinate().isValid()) {
+        _updateTerrainTimer.start();
-                // We use a timer so that any additional requests before the timer fires result in only a single request
+    } else {
-                _updateTerrainTimer.start();
+        _terrainAltitude = qQNaN();
-            }
-        } else {
-            _terrainAltitude = qQNaN();
-        }
     }
 }