pid tuning: fix layouting

- use correct available height for chart (fill height)
- show scrollbar if param list overflows the window size

src/AutoPilotPlugins/PX4/PX4TuningComponentCopter.qml

@@ -22,6 +22,7 @@ SetupPage {
         id: pageComponent
 
         PX4TuningComponentCopterAll {
+            height: availableHeight
         }
     } // Component - pageComponent
 } // SetupPage

src/AutoPilotPlugins/PX4/PX4TuningComponentCopterAll.qml

@@ -53,5 +53,6 @@ Item {
         width:             parent.width
         anchors.top:       bar.bottom
         anchors.topMargin: ScreenTools.defaultFontPixelWidth
+        anchors.bottom:    parent.bottom
     }
 }

src/AutoPilotPlugins/PX4/PX4TuningComponentCopterAttitude.qml

@@ -18,8 +18,9 @@ import QGroundControl.FactControls  1.0
 import QGroundControl.ScreenTools   1.0
 import QGroundControl.Vehicle       1.0
 
-Column {
+ColumnLayout {
     width: availableWidth
+    anchors.fill: parent
 
     PIDTuning {
         width: availableWidth
@@ -75,8 +76,6 @@ Column {
                 }
             }
         }
-        anchors.left:   parent.left
-        anchors.right:  parent.right
         title: "Attitude"
         tuningMode: Vehicle.ModeRateAndAttitude
         unit: "deg"

src/AutoPilotPlugins/PX4/PX4TuningComponentCopterPosition.qml

@@ -18,8 +18,9 @@ import QGroundControl.FactControls  1.0
 import QGroundControl.ScreenTools   1.0
 import QGroundControl.Vehicle       1.0
 
-Column {
+ColumnLayout {
     width: availableWidth
+    anchors.fill: parent
     property Fact _mcPosMode:       controller.getParameterFact(-1, "MPC_POS_MODE", false)
 
     GridLayout {
@@ -73,8 +74,6 @@ Column {
                 }
             }
         }
-        anchors.left:   parent.left
-        anchors.right:  parent.right
         title: "Position"
         tuningMode: Vehicle.ModeVelocityAndPosition
         unit: "m"

src/AutoPilotPlugins/PX4/PX4TuningComponentCopterRate.qml

@@ -18,8 +18,9 @@ import QGroundControl.FactControls  1.0
 import QGroundControl.ScreenTools   1.0
 import QGroundControl.Vehicle       1.0
 
-Column {
+ColumnLayout {
     width: availableWidth
+    anchors.fill: parent
     property Fact _airmode:           controller.getParameterFact(-1, "MC_AIRMODE", false)
     property Fact _thrustModelFactor: controller.getParameterFact(-1, "THR_MDL_FAC", false)
 
@@ -143,8 +144,6 @@ Column {
                 }
             }
         }
-        anchors.left:   parent.left
-        anchors.right:  parent.right
         title: "Rate"
         tuningMode: Vehicle.ModeRateAndAttitude
         unit: "deg/s"

src/AutoPilotPlugins/PX4/PX4TuningComponentCopterVelocity.qml

@@ -18,8 +18,9 @@ import QGroundControl.FactControls  1.0
 import QGroundControl.ScreenTools   1.0
 import QGroundControl.Vehicle       1.0
 
-Column {
+ColumnLayout {
     width: availableWidth
+    anchors.fill: parent
     property Fact _mcPosMode:       controller.getParameterFact(-1, "MPC_POS_MODE", false)
 
     GridLayout {
@@ -105,8 +106,6 @@ Column {
                 }
             }
         }
-        anchors.left:   parent.left
-        anchors.right:  parent.right
         title: "Velocity"
         tuningMode: Vehicle.ModeVelocityAndPosition
         unit: "m/s"

src/AutoPilotPlugins/PX4/PX4TuningComponentPlane.qml

@@ -22,6 +22,7 @@ SetupPage {
         id: pageComponent
 
         PX4TuningComponentPlaneAll {
+            height: availableHeight
         }
     } // Component - pageComponent
 } // SetupPage

src/AutoPilotPlugins/PX4/PX4TuningComponentPlaneAll.qml

@@ -41,5 +41,6 @@ Item {
         width:             parent.width
         anchors.top:       bar.bottom
         anchors.topMargin: ScreenTools.defaultFontPixelWidth
+        anchors.bottom:    parent.bottom
     }
 }

src/AutoPilotPlugins/PX4/PX4TuningComponentPlaneTECS.qml

@@ -18,8 +18,9 @@ import QGroundControl.FactControls  1.0
 import QGroundControl.ScreenTools   1.0
 import QGroundControl.Vehicle       1.0
 
-Column {
+ColumnLayout {
     width: availableWidth
+    anchors.fill: parent
 
     PIDTuning {
         width: availableWidth
@@ -43,8 +44,6 @@ Column {
             }
             // TODO: add other params
         }
-        anchors.left:   parent.left
-        anchors.right:  parent.right
         title: "TECS"
         tuningMode: Vehicle.ModeAltitudeAndAirspeed
         unit: ""

src/AutoPilotPlugins/PX4/PX4TuningComponentVTOL.qml

@@ -24,6 +24,7 @@ SetupPage {
 
         Item {
             width: availableWidth
+            height: availableHeight
 
             FactPanelController {
                 id:         controller
@@ -52,6 +53,7 @@ SetupPage {
                 width:             parent.width
                 anchors.top:       bar.bottom
                 anchors.topMargin: ScreenTools.defaultFontPixelWidth
+                anchors.bottom:    parent.bottom
             }
         }
     } // Component - pageComponent

src/QmlControls/PIDTuning.qml

@@ -165,10 +165,18 @@ RowLayout {
         property int _maxPointCount:    10000 / interval
     }
 
+    QGCFlickable {
+        contentWidth:           parent.width * (_showCharts ? 0.4 : 1)
+        contentHeight:          rightColumn.height
+        Layout.fillHeight:      true
+        Layout.minimumWidth:    contentWidth
+        Layout.maximumWidth:    contentWidth
+        Layout.alignment:       Qt.AlignTop
         Column {
             spacing:            _margins
             Layout.alignment:   Qt.AlignTop
-        width:          parent.width * (_showCharts ? 0.4 : 1)
+            width:          parent.width
+            id:             rightColumn
 
             Column {
 
@@ -238,19 +246,17 @@ RowLayout {
                 }
             }
         }
+    }
 
-    Column {
+    ColumnLayout {
-        Layout.fillWidth: true
-        Layout.alignment:   Qt.AlignTop
         visible:            _showCharts
 
         ChartView {
             id:                 chart
-            anchors.left:       parent.left
-            anchors.right:      parent.right
-            height:             availableHeight * 0.75
             antialiasing:       true
             legend.alignment:   Qt.AlignBottom
+            Layout.fillHeight:  true
+            Layout.fillWidth:   true
 
             // enable mouse dragging
             MouseArea {