Browse Source

SerialLink: Use qobject_cast instead of dynamic_cast

qobject_cast is times faster dynamic_cast for objects that
inherit QObject. also, use auto keyword to not duplicate
class names.
QGC4.4
Tomaz Canabrava 6 years ago committed by Daniel Agar
parent
commit
bc52987ea6
  1. 4
      src/comm/SerialLink.cc

4
src/comm/SerialLink.cc

@ -405,7 +405,7 @@ SerialConfiguration::SerialConfiguration(SerialConfiguration* copy) : LinkConfig @@ -405,7 +405,7 @@ SerialConfiguration::SerialConfiguration(SerialConfiguration* copy) : LinkConfig
void SerialConfiguration::copyFrom(LinkConfiguration *source)
{
LinkConfiguration::copyFrom(source);
SerialConfiguration* ssource = dynamic_cast<SerialConfiguration*>(source);
auto* ssource = qobject_cast<SerialConfiguration*>(source);
if (ssource) {
_baud = ssource->baud();
_flowControl = ssource->flowControl();
@ -423,7 +423,7 @@ void SerialConfiguration::copyFrom(LinkConfiguration *source) @@ -423,7 +423,7 @@ void SerialConfiguration::copyFrom(LinkConfiguration *source)
void SerialConfiguration::updateSettings()
{
if(_link) {
SerialLink* serialLink = dynamic_cast<SerialLink*>(_link);
auto* serialLink = qobject_cast<SerialLink*>(_link);
if(serialLink) {
serialLink->_resetConfiguration();
}

Loading…
Cancel
Save