From bc52987ea637d56cdf526e67c6bfa640b001541d Mon Sep 17 00:00:00 2001 From: Tomaz Canabrava Date: Mon, 19 Aug 2019 11:40:25 +0200 Subject: [PATCH] SerialLink: Use qobject_cast instead of dynamic_cast qobject_cast is times faster dynamic_cast for objects that inherit QObject. also, use auto keyword to not duplicate class names. --- src/comm/SerialLink.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/comm/SerialLink.cc b/src/comm/SerialLink.cc index f9b5624..819bbcb 100644 --- a/src/comm/SerialLink.cc +++ b/src/comm/SerialLink.cc @@ -405,7 +405,7 @@ SerialConfiguration::SerialConfiguration(SerialConfiguration* copy) : LinkConfig void SerialConfiguration::copyFrom(LinkConfiguration *source) { LinkConfiguration::copyFrom(source); - SerialConfiguration* ssource = dynamic_cast(source); + auto* ssource = qobject_cast(source); if (ssource) { _baud = ssource->baud(); _flowControl = ssource->flowControl(); @@ -423,7 +423,7 @@ void SerialConfiguration::copyFrom(LinkConfiguration *source) void SerialConfiguration::updateSettings() { if(_link) { - SerialLink* serialLink = dynamic_cast(_link); + auto* serialLink = qobject_cast(_link); if(serialLink) { serialLink->_resetConfiguration(); }