Browse Source

Merge pull request #6066 from DonLakeFlyer/FixLeaks

Fix leaking QNetworkReply
QGC4.4
Don Gagne 7 years ago committed by GitHub
parent
commit
c5b8d4e029
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
  1. 3
      src/QGCFileDownload.cc

3
src/QGCFileDownload.cc

@ -96,6 +96,7 @@ void QGCFileDownload::_downloadFinished(void)
// When an error occurs or the user cancels the download, we still end up here. So bail out in // When an error occurs or the user cancels the download, we still end up here. So bail out in
// those cases. // those cases.
if (reply->error() != QNetworkReply::NoError) { if (reply->error() != QNetworkReply::NoError) {
reply->deleteLater();
return; return;
} }
@ -128,6 +129,8 @@ void QGCFileDownload::_downloadFinished(void)
qWarning() << errorMsg; qWarning() << errorMsg;
emit error(errorMsg); emit error(errorMsg);
} }
reply->deleteLater();
} }
/// @brief Called when an error occurs during download /// @brief Called when an error occurs during download

Loading…
Cancel
Save