More signal / slot conversion

The overloaded member signal just hit us, to use it is a pain
but the resuting code is faster and less error prone, so it's
still a good thing to do.

Signed-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com>

src/QGCApplication.cc

@@ -434,7 +434,7 @@ bool QGCApplication::_initForNormalAppBoot(void)
     _loadCurrentStyle();
 
     // Exit main application when last window is closed
-    connect(this, SIGNAL(lastWindowClosed()), this, SLOT(quit()));
+    connect(this, &QGCApplication::lastWindowClosed, this, QGCApplication::quit);
 
 #ifdef __mobile__
     _qmlAppEngine = new QQmlApplicationEngine(this);

src/QGCFileDownload.cc

@@ -81,7 +81,8 @@ bool QGCFileDownload::download(const QString& remoteFile)
 
     connect(networkReply, &QNetworkReply::downloadProgress, this, &QGCFileDownload::downloadProgress);
     connect(networkReply, &QNetworkReply::finished, this, &QGCFileDownload::_downloadFinished);
-    connect(networkReply, SIGNAL(error(QNetworkReply::NetworkError)), this, SLOT(_downloadError(QNetworkReply::NetworkError)));
+    connect(networkReply, static_cast<void (QNetworkReply::*)(QNetworkReply::NetworkError)>(&QNetworkReply::error),
+            this, &QGCFileDownload::_downloadError);
 
     return true;
 }

src/QGCFileDownload.h

@@ -43,7 +43,7 @@ signals:
     void downloadFinished(QString remoteFile, QString localFile);
     void error(QString errorMsg);
 
-private slots:
+private:
     void _downloadFinished(void);
     void _downloadError(QNetworkReply::NetworkError code);
 };

src/QmlControls/QmlObjectListModel.cc

@@ -151,7 +151,7 @@ void QmlObjectListModel::clear(void)
 QObject* QmlObjectListModel::removeAt(int i)
 {
     QObject* removedObject = _objectList[i];
-    
+
     // Look for a dirtyChanged signal on the object
     if (_objectList[i]->metaObject()->indexOfSignal(QMetaObject::normalizedSignature("dirtyChanged(bool)")) != -1) {
         if (!_skipDirtyFirstItem || i != 0) {

src/QtLocationPlugin/OpenPilotMaps.cc

@@ -205,9 +205,11 @@ void UrlFactory::_tryCorrectGoogleVersions()
 #endif
         qheader.setRawHeader("User-Agent", userAgent);
         _googleReply = _network->get(qheader);
-        connect(_googleReply, SIGNAL(finished()), this, SLOT(_googleVersionCompleted()));
-        connect(_googleReply, SIGNAL(error(QNetworkReply::NetworkError)), this, SLOT(_networkReplyError(QNetworkReply::NetworkError)));
-        connect(_googleReply, SIGNAL(destroyed()), this, SLOT(_replyDestroyed()));
+        connect(_googleReply, &QNetworkReply::finished, this, &UrlFactory::_googleVersionCompleted);
+        connect(_googleReply, &QNetworkReply::destroyed, this, &UrlFactory::_replyDestroyed);
+
+        connect(_googleReply, static_cast<void (QNetworkReply::*)(QNetworkReply::NetworkError)>(&QNetworkReply::error),
+                this, &UrlFactory::_networkReplyError);
         _network->setProxy(proxy);
     }
 }