fix rendering of advanced parameters editors

src/ui/QGCBaseParamWidget.cc

@@ -25,6 +25,7 @@ QGCBaseParamWidget* QGCBaseParamWidget::initWithUAS(UASInterface *uas)
 
 void QGCBaseParamWidget::setUAS(UASInterface* uas)
 {
+    if (uas != mav) {
         if (mav) {
             //TODO disconnect any connections as needed
             disconnectViewSignalsAndSlots();
@@ -42,6 +43,7 @@ void QGCBaseParamWidget::setUAS(UASInterface* uas)
 
             paramMgr->requestParameterListIfEmpty();
         }
+    }
 
 }
 

src/ui/QGCPX4VehicleConfig.cc

@@ -84,15 +84,16 @@ QGCPX4VehicleConfig::QGCPX4VehicleConfig(QWidget *parent) :
     //connect(ui->setTrimButton, SIGNAL(clicked()), this, SLOT(setTrimPositions()));
 
     //TODO connect buttons here to save/clear actions?
-    mav = UASManager::instance()->getActiveUAS();
+    UASInterface* tmpMav = UASManager::instance()->getActiveUAS();
-    if (!mav) {
+    if (tmpMav) {
-        qWarning() << "No active mav! ";
+        ui->pendingCommitsWidget->initWithUAS(tmpMav);
-    }
-    else {
-        ui->pendingCommitsWidget->initWithUAS(mav);
         ui->pendingCommitsWidget->update();
+        setActiveUAS(tmpMav);
     }
 
+    connect(UASManager::instance(), SIGNAL(activeUASSet(UASInterface*)),
+            this, SLOT(setActiveUAS(UASInterface*)));
+
     //TODO the following methods are not yet implemented
 
 //    Connect RC mapping assignments
@@ -115,9 +116,9 @@ QGCPX4VehicleConfig::QGCPX4VehicleConfig(QWidget *parent) :
 //    connect(ui->invertCheckBox_7, SIGNAL(clicked(bool)), this, SLOT(setAux2Inverted(bool)));
 //    connect(ui->invertCheckBox_8, SIGNAL(clicked(bool)), this, SLOT(setAux3Inverted(bool)));
 
-    connect(UASManager::instance(), SIGNAL(activeUASSet(UASInterface*)), this, SLOT(setActiveUAS(UASInterface*)));
 
-    setActiveUAS(UASManager::instance()->getActiveUAS());
+
+
 
     for (unsigned int i = 0; i < chanMax; i++) {
         rcValue[i] = UINT16_MAX;
@@ -1248,6 +1249,7 @@ void QGCPX4VehicleConfig::parameterChanged(int uas, int component, QString param
         return;
     }
 
+    //TODO this may introduce a bug with param editor widgets not receiving param updates
     if (parameterName.startsWith("RC")) {
         handleRcParameterChange(parameterName,value);
         return;