The text can be translated, the text can have accelerator-special
key, so the text is unrealiable. the only thing reliable is the data,
wich stores a pointer to a fixed , unmutable, string.
Signed-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com>
Since the Static const char * items are private and nothing
should access them besides the MainWindow class, declare
them inside of the .cpp file with static linkage, this way
a few good things happen: they are not exported as symbols
to any other class (not even with private linkage) and also
if we need to add a new one, on the .cpp, the only compiled
file will be the cpp, instead of the tons of files that include
mainwindow.h
Signed-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com>
If you choosed View->Fullscreen, the app would go to fullscreen,
but if you then go again to View->Fullscreen, the app would still
be fullscreen but the menu item would be unselected - leaving
UI and settings inconsistent.
Signed-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com>
qobject_cast doesn't use RTTI to figure out the type, it uses
an internally stored relationship, wich is much faster than
RTTI. I grepped the code for dynamic_cast and there are lots
besides this one, so I'll later try to figure out wich ones
are QObject inheritances and change acordingly.
Signed-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com>
* mavlink/master:
Making Altitude text Larger than the rest.
Saving and Restoring "Map Is Main"
Controls work better aesthetically when centered on the screen.
More work on the Fly View
The current monitor used was the 'default' one, the primary monitor
but if your default monitor was the laptop one, with the lid closed
like mine was for quite a bit, you'd spend like 20 minutes trying to
find the preferences dialog, like I did.
Signed-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com>
if an unknown string was passed to createInnerDockidget,
the widget would not be created but a reference to the null
pointer would still be saved on the avaliable dock widgets,
and thus any code that foreached the list accessing methods
could led to a crash.
Signed-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com>
Since it's just a state-toogler, use the return value of the
method to set the values directly.
Signed-off-by: Tomaz Canabrava <tomaz.canabrava@intel.com>
* mavlink/master:
update android version
qmake cleanup git version
travis-ci enable ccache for linux
travis-ci switch linux to container infrastructure
travis-ci disable android debug
Fix mode selection coloring
Fix binding loop
Decimal place support from meta data
Fix item dragging
Fix home position handling
Fix signalling
Decimal place support from meta data
Fix item dragging
Fix home position handling
Fix signalling
Move ParameterLoader override to FirmwarePlugin
Tomaz Canabrava
Don Gagne
dogmaphobic
David Goodman
Daniel Agar