The Android build on CI failed with the following error
message:
../../qgroundcontrol/qgroundcontrol/src/QtLocationPlugin/QGCTileCacheWorker.cpp:510:21: error: variable 'tileCount' set but not used [-Werror,-Wunused-but-set-variable]
221
quint64 tileCount = 0;
The tileCount variable is not used. I removed the variable.
The compilation on MacOS stops with the following compile error:
/Users/fritz/searchwing/qgroundcontrol/src/Vehicle/Actuators/Actuators.cc:431:26: error: loop variable 'parameterJson' is always a copy because the range of type 'QJsonArray' does not return a reference [-Werror,-Wrange-loop-analysis]
for (const auto& parameterJson : parameters) {
"QNmeaPositionInfoSource supports reporting the accuracy of the
horizontal and vertical position. To enable position accuracy reporting
an estimate of the User Equivalent Range Error associated with the NMEA
source must be set with setUserEquivalentRangeError."
Source: https://doc.qt.io/qt-6/qnmeapositioninfosource.html#details
Commit 2a9ecabad8 introduced new behaviour
that broke use of external GPS. This change fixes the problem reported
in https://github.com/mavlink/qgroundcontrol/issues/10271.
Currently when adding a hostname in string form for tcp connection,
resolving to IP is done immediately, and in case of an error
the host is not stored and used default one instead.
Also the ip might be not known when adding the config, but hostname is known,
which also might be not resolvable at time when the config is being created.
Since hostName in QAbstractSocket::connectToHost
may be an IP address in string form (e.g., "43.195.83.32"),
or it may be a host name (e.g., "example.com").
QAbstractSocket will do a lookup only if required.
So suggesting to totally remove resolving of ip from TCPLink.
Resolving will be performed in QTcpSocket::connectToHost() when actual connection is requested.
We are using the generic vendor id available on te bootloader which is set to Auterion, we plan to change that at some point to either Dronecode or Pixhawk, we realize its not ideal but it will have to do for now.
Philipp Borgers
Friedrich Beckmann
Akash Patel
David Jablonski
Val Doroshchuk
aib
Tzuriel Lampner
Tzuriel Lampner
Holden
PX4BuildBot
bnsgeyer
lss
Vasily Evseenko
Willian Galvani
Beat Küng
Ramon Roche
Vincent Poon